JSON, REXML, and ruby 1.9.3 works again! #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edolnx I'm not sure if this patch helps your journey on #1949, but maybe it does? I was able to produce deb and rpm packages with fpm 1.14.2 (plus this PR's patch) using Ruby 1.9.3 from the docker ruby:1.9.3 container image. |
This was referenced Nov 3, 2022
jordansissel
force-pushed
the
issue/1949/support-old-rubies
branch
from
9a6be36
to
3b8645e
Compare
jordansissel
changed the title
|
I did a bit of digging tonight and found a few open issues related to |
The 14 pending tests are because I don't have virtualenv setup on my workstation. |
The original `json` gem dependency was added in the original fpm.gemspec because, at the time, Ruby 1.8.7 was common and required an external `json` dependency for parsing JSON. Later, Ruby releases since 1.9.1 have bundled `json`[1]. Therefore, it feels safe to remove this dependency. As a bonus, the rubygems `json` gem places requirements on the minimum version of Ruby. At this time, the latest `json` gem requires Ruby >= 2.3. If the `json` gem dependency is removed, fpm will still retain the ability to process JSON while lowering the minimum required Ruby version to Ruby 1.9.x -- It's not perfect, but it's a start! :) [1] https://docs.ruby-lang.org/en/2.3.0/NEWS-1_9_1.html The idea for this change change came originally from a discussion with @edolnx in #1949 Fixes #1741, #1264, #1949
On older versions of rubygems, `Gem::Version.new(...)` calls `String#strip!` on the argument in the constructor. This causes a problem on Ruby 1.9.3 where the RUBY_VERSION constant is a frozen string. The workaround is to make a copy of this string that is unfrozen, and `String#dup` seems to work :)
jordansissel
force-pushed
the
issue/1949/support-old-rubies
branch
from
3b8645e
to
ac0ecdd
Compare
|
fpm 1.15.0 is released and contains this improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows at least some of fpm to work under Ruby 1.9.3. I can produce rpms and debs using Ruby 1.9.3 and this patch!
The
osxpkgformat doesn't seem to work for me on Ruby 1.9.3 because REXML seems to crash with an error.This is accomplished by:
jsondependency which has been included in Ruby by default since Ruby 1.9.1rubygemsunder Ruby 1.9.3You, reader, may be asking, "Why?"
In #1949, we discuss raising the minimum version of ruby required by fpm. At time of writing, the minimum version is set to '>= 1.9.3', and I'm somewhat slow to raise it without good cause.
Historically, there's been a race for some Ruby libraries to abandon older versions of ruby. However, as a sysadmin, I'm keenly aware that many folks may not have the authority to upgrade Ruby on their systems, so it feels natural to continue keep fpm compatible with older versions of Ruby.
I've tried to be consistent in this strategy:
Related issues: