Introduced a dependency mapping for != dependency #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There exist gems in the wild that have a dependency != Example is sprocket gem (at least version 2.1.3). Use a mapping that prevents dpkg to choke on != and appended it to the conflicts.
| @@ -261,6 +261,13 @@ def fix_dependency(dep) | |||
| nextversion[l-1] = 0 | |||
| nextversion = nextversion.join(".") | |||
| return ["#{name} (>= #{version})", "#{name} (<< #{nextversion})"] | |||
| elsif (m = dep.match(/(\S+)\s+\(!= (.+)\)/)) | |||
There was a problem hiding this comment.
Is this really what is meant by !=?
As an alternate, what if instead of adding a dependency, the '!=' dependency adds a 'Conflicts' entry?
There was a problem hiding this comment.
Dammit, uploaded the wrong patch. Stay tuned, will upload the correct one after dinner...
Added correct patch now.
| elsif (m = dep.match(/(\S+)\s+\(!= (.+)\)/)) | ||
| # Append this to conflicts | ||
| self.conflicts += [dep.gsub(/!=/,"=")] | ||
| return [] |
|
grr, wrong click ;) |
jordansissel
added a commit
that referenced
this pull request
May 23, 2012
Introduced a dependency mapping for != dependency using Conflicts in deb instead of a Depends
prof-milki
pushed a commit
to prof-milki/xpm
that referenced
this pull request
Dec 18, 2014
Introduced a dependency mapping for != dependency using Conflicts in deb instead of a Depends
prof-milki
pushed a commit
to prof-milki/xpm
that referenced
this pull request
Dec 27, 2014
Introduced a dependency mapping for != dependency using Conflicts in deb instead of a Depends
jordansissel
added a commit
that referenced
this pull request
Apr 24, 2015
Introduced a dependency mapping for != dependency using Conflicts in deb instead of a Depends
jordansissel
added a commit
that referenced
this pull request
Jun 20, 2016
Introduced a dependency mapping for != dependency using Conflicts in deb instead of a Depends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There exist gems in the wild that have a dependency !=
Example is sprocket gem (at least version 2.1.3). Use a mapping
that prevents dpkg to choke on != and appended it to the conflicts.