New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced a dependency mapping for != dependency #221

Merged
merged 2 commits into from May 23, 2012

Conversation

Projects
None yet
2 participants
@svenihoney
Contributor

svenihoney commented May 15, 2012

There exist gems in the wild that have a dependency !=
Example is sprocket gem (at least version 2.1.3). Use a mapping
that prevents dpkg to choke on != and appended it to the conflicts.

Introduced a dependency mapping for != dependency
There exist gems in the wild that have a dependency !=
Example is sprocket gem (at least version 2.1.3). Use a mapping
that prevents dpkg to choke on != and appended it to the conflicts.
@@ -261,6 +261,13 @@ def fix_dependency(dep)
nextversion[l-1] = 0
nextversion = nextversion.join(".")
return ["#{name} (>= #{version})", "#{name} (<< #{nextversion})"]
elsif (m = dep.match(/(\S+)\s+\(!= (.+)\)/))

This comment has been minimized.

@jordansissel

jordansissel May 15, 2012

Owner

Is this really what is meant by !=?

As an alternate, what if instead of adding a dependency, the '!=' dependency adds a 'Conflicts' entry?

This comment has been minimized.

@svenihoney

svenihoney May 15, 2012

Contributor

Dammit, uploaded the wrong patch. Stay tuned, will upload the correct one after dinner...

elsif (m = dep.match(/(\S+)\s+\(!= (.+)\)/))
# Append this to conflicts
self.conflicts += [dep.gsub(/!=/,"=")]
return []

This comment has been minimized.

@jordansissel

jordansissel May 23, 2012

Owner

Looks good.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented May 23, 2012

grr, wrong click ;)

jordansissel added a commit that referenced this pull request May 23, 2012

Merge pull request #221 from svenihoney/debian_fix_unequal
Introduced a dependency mapping for != dependency using Conflicts in deb instead of a Depends

@jordansissel jordansissel merged commit ac5a399 into jordansissel:master May 23, 2012

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#221 from svenihoney/debian_fix_unequal
Introduced a dependency mapping for != dependency using Conflicts in deb instead of a Depends

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#221 from svenihoney/debian_fix_unequal
Introduced a dependency mapping for != dependency using Conflicts in deb instead of a Depends

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #221 from svenihoney/debian_fix_unequal
Introduced a dependency mapping for != dependency using Conflicts in deb instead of a Depends

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #221 from svenihoney/debian_fix_unequal
Introduced a dependency mapping for != dependency using Conflicts in deb instead of a Depends
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment