-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New error when pushing to Heroku #13
Comments
Think this is due to 0.6 - http://install.meteor.com/ no longer has reference to VERSION anywhere which I think the buildpack expects? |
Any idea how to solve this? |
Not really - you could try hard coding the URL of the 0.6 meteor install package - the URL is https://d3fm2vapipm3k9.cloudfront.net/bootstrap/0.6.0/meteor-bootstrap-Linux_i686.tar.gz Ben Rometsch (http://flavors.me/dabeeeenster) - Director On Friday, 5 April 2013 at 17:38, dimfisch wrote:
|
Looks like the meteor folks completely rewrote their install script, so the 'compile' script for the buildpack will need to be fixed to compensate. |
Thanks, Jordan. Any idea how soon this can be done? Any help needed? (not that I think I can help much, but still, I'd be willing to give it a shot :) |
No ETA for me, probably would be easy for someone to patch though. |
Any chance you could spend a few minutes with me on Skype to give me a sense of what needs to be done and how? |
I have been looking at this. I tried hardcoding the version number into
As far as I can see it might be related to the path, but I really am guessing here. I'll do some more hacking in the morning. |
On a side note: it really would make sense to detect the appropriate version of meteor for a given project, instead of just assuming that you want the latest version. |
Totally agree. I'm developing on Windows, so still on 0.5.9 |
Indeed; open to support for that. Probably worth looking into how the ruby buildpack does it (which I believe has version selections) |
@madsmao given that the meteor project itself is now doing this it would seem like the right way to go. There's also a hard dependency on that install.meteor.com script which is a shame as it could break this project in the future... |
I am still working on fixing this issue. I appreciate any support on this issue, as I am a total noob when it comes to buildpacks (the debugging workflow has it's quirks). I am currently at a point where I feel the need to pretty much start from scratch and embrace the new features introduced in Meteor 0.6.0 for version control etc. @dabeeeenster you are right that the hard dependency on install.meteor.com is not cool. I pretty much see two ways to avoid this:
The first approach will probably make the build script run faster, whereas the second approach might cause less issues down the road if the Meteor team decides to make changes to install.meteor.com. I'll go with the first option for now (if I can get it working) because I believe it is the fastest path to a working buildpack. |
I now have a working buildpack that supports 0.6.0. Feel free to take it for a spin! This app is running on the new buildpack: http://v8s-bp.herokuapp.com/ CAUTION: This is very much a work in progress. I have yet to test that stuff like database access actually works, but I thought I would let you guys know. It's also worth mentioning that my changes will probably make the buildpack incompatible with earlier releases of Meteor. I'll continue my work on this and keep you guys posted. |
I have made a bit of a mess of my commit history (tried to clean all my 'Random commit' messages out of the log). Hope things will still work for everyone. |
Have you tested it with the database stuff? I'd like to use this, but I'm slightly worried that it'll just break everything in my db since you mentioned it. |
I tested it with a database and everything works as expected. Can't hurt to do a quick backup first though. |
Just to be clear, this is just for 0.6.0, any other version won't work, right? |
Correct. Older versions won't work. Future versions should though. |
Would it be complicated to add support for 0.5.9? |
Making the buildpack work like it did 5 days ago (just for 0.5.9) should be possible by creating a fork of @jordansissel's code and simply hardcoding the version number into |
Wow! As simple as that, huh?! PACKAGE=meteor_${VERSION}-1_amd64.deb with PACKAGE=meteor_0.5.9-1_amd64.deb ? |
Yeah, that should do it. Give it a try :-) |
Also, you can comment out the line(s) that fetch information about the version number from install.meteor.com. |
Didn't work, I got the following error: I don't think it likes the dots in that file name. On your second reply, which lines are you referring to? |
you can make it tunable using an environment variable to set the version instead of querying it from meteor.com; this would let you use heroku config to set the version of meteor. |
I can probably cobble together a hack that supports you setting METEOR_VERSION |
Looks like heroku buildpacks have changed behavior?
Looks like CACHE_DIR isn't valid anymore? Wonderful times... |
I've confirmed master of this buildpack repo now works for meteor apps. |
I'll have a go adding 0.6.x support too |
Best I can tell, 'heroku config' environment variables are not exposed to the 'compile' step
|
Based on the above, I do not know if it is possible to make the version of meteor configurable. I expected the 'ruby' buildpack to show signs of version choosing, but it does not. Even the Ruby buildpack, which is probably 'state of the art' in terms of buildpack practices, says that if you want to change the version of something to fork the buildpack and edit the hard-coded versions in the config. |
Marking closed. |
If it's useful, there's a Heroku Labs feature that lets you set env vars during slug compilation: https://devcenter.heroku.com/articles/labs-user-env-compile |
I wonder if it has anything to do with the fact that version 0.6.0 of Meteor just came out.
Unpacking meteor
ar: /app/tmp/repo.git/.cache/meteor_-1_amd64.deb: File format not recognized
gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Exiting with failure status due to previous errors
Building meteor bundle
/tmp/buildpack_quv2v4nfwlql/bin/compile: 40: meteor: not found
tar: /app/tmp/repo.git/.cache/bundle.tar.gz: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
tar: Child returned status 2
tar: Exiting with failure status due to previous errors
rm: cannot remove `/app/tmp/repo.git/.cache/bundle.tar.gz': No such file or directory
The text was updated successfully, but these errors were encountered: