-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing menu leftside #3
Fixing menu leftside #3
Conversation
the layout of left side is quite ok, but I'm struggle to make this dropdown works, do you have any idea what is the problem @jordisala1991 |
Hi! Can you avoid all the indentation changes? That should go to another PR. Let's try to keep the original PR as clean as possible, with the minimum changes required to make this work. |
90c1ece
to
d413c2a
Compare
fd8881b
to
d2cc555
Compare
d2cc555
to
91a0c91
Compare
I guess I removed the indentation changes 😄 @jordisala1991 do you know how to add this js/css files : ColorlibHQ/AdminLTE#4304 (comment) if not I can check how to add this :) Edit 1: do you know if this line import: scrollbarOverlays and adminlte (cs/js) ? |
Thank you! |
Do you know if scrollbarOverlays is part of admin lte or is it another library? To add it, we should know that first, but it should be added to the same file we included the main admin lte js, searching for it on node_modules. I can do it if you want. Just dont have a lot of time for OSS. |
I have done some research, maybe is this one: https://github.com/KingSora/OverlayScrollbars It might need to be installed and added to css/js |
I think it make part of adminlte, I didn't see this in extra components 👀👀
Well if you could add this will be nice, because i Will unblock me, and I
could see others things related with adminlte V3.
…On Mon, Mar 7, 2022, 6:36 PM Jordi Sala Morales ***@***.***> wrote:
I guess I removed the indentation changes 😄
@jordisala1991 <https://github.com/jordisala1991> do you know how to add
this js/css files : ColorlibHQ/AdminLTE#4304 (comment)
<ColorlibHQ/AdminLTE#4304 (comment)>
if not I can check how to add this :)
Edit 1: do you know if this line
https://github.com/sonata-project/SonataAdminBundle/pull/7740/files#diff-2126216ecd2ff9ae9b5f0c1e84d8fecb4ee4e54dc21685f69a590c2162dec186L41
import: scrollbarOverlays and adminlte (cs/js) ?
Do you know if scrollbarOverlays is part of admin lte or is it another
library?
To add it, we should know that first, but it should be added to the same
file we included the main admin lte js, searching for it on node_modules.
I can do it if you want. Just dont have a lot of time for OSS.
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQQNYZVGQMSJ7MFP5OSL33U6Y5ATANCNFSM5P5WCXTQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hmmmm does it should be added by yarn and webpack? And after that add in
app.js?
…On Mon, Mar 7, 2022, 6:39 PM Jordi Sala Morales ***@***.***> wrote:
I have done some research, maybe is this one:
https://github.com/KingSora/OverlayScrollbars
It might need to be installed and added to css/js
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQQNYYKOLQGNBS4PY2ZVGDU6Y5NHANCNFSM5P5WCXTQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thats the idea, but if you want to take a look on the other parts of the compatibility I can take care of this |
Nice then I'll fix the list view ;) |
No description provided.