Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing menu leftside #3

Conversation

eerison
Copy link

@eerison eerison commented Mar 4, 2022

No description provided.

@eerison
Copy link
Author

eerison commented Mar 4, 2022

Screenshot 2022-03-02 at 22 29 12

the layout of left side is quite ok, but I'm struggle to make this dropdown works, do you have any idea what is the problem @jordisala1991

@jordisala1991
Copy link
Owner

Hi! Can you avoid all the indentation changes? That should go to another PR. Let's try to keep the original PR as clean as possible, with the minimum changes required to make this work.

@eerison eerison force-pushed the fix-navbar-leftside branch 2 times, most recently from fd8881b to d2cc555 Compare March 7, 2022 13:45
@eerison
Copy link
Author

eerison commented Mar 7, 2022

I guess I removed the indentation changes 😄

@jordisala1991 do you know how to add this js/css files : ColorlibHQ/AdminLTE#4304 (comment)

if not I can check how to add this :)

Edit 1: do you know if this line

https://github.com/sonata-project/SonataAdminBundle/pull/7740/files#diff-2126216ecd2ff9ae9b5f0c1e84d8fecb4ee4e54dc21685f69a590c2162dec186L41

import: scrollbarOverlays and adminlte (cs/js) ?

@jordisala1991 jordisala1991 merged commit bc94f0a into jordisala1991:feature/upgrade-admin-lte Mar 7, 2022
@jordisala1991
Copy link
Owner

Thank you!

@jordisala1991
Copy link
Owner

I guess I removed the indentation changes 😄

@jordisala1991 do you know how to add this js/css files : ColorlibHQ/AdminLTE#4304 (comment)

if not I can check how to add this :)

Edit 1: do you know if this line

https://github.com/sonata-project/SonataAdminBundle/pull/7740/files#diff-2126216ecd2ff9ae9b5f0c1e84d8fecb4ee4e54dc21685f69a590c2162dec186L41

import: scrollbarOverlays and adminlte (cs/js) ?

Do you know if scrollbarOverlays is part of admin lte or is it another library?

To add it, we should know that first, but it should be added to the same file we included the main admin lte js, searching for it on node_modules.

I can do it if you want. Just dont have a lot of time for OSS.

@jordisala1991
Copy link
Owner

I have done some research, maybe is this one: https://github.com/KingSora/OverlayScrollbars

It might need to be installed and added to css/js

@eerison
Copy link
Author

eerison commented Mar 7, 2022 via email

@eerison
Copy link
Author

eerison commented Mar 7, 2022 via email

@jordisala1991
Copy link
Owner

Hmmmm does it should be added by yarn and webpack? And after that add in
app.js?

Thats the idea, but if you want to take a look on the other parts of the compatibility I can take care of this

@eerison
Copy link
Author

eerison commented Mar 7, 2022

Nice then I'll fix the list view ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants