-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unexpected quote escaping in string resource #1292
Conversation
SimonMarquis
commented
Apr 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Oh, interesting.
Not sure what's wrong. Wrapping in double quotes would probably fix the issue. But testing this is kinda tricky on a smartphone 😅 |
@@ -31,7 +31,7 @@ | |||
<string name="oops">Oops something went wrong</string> | |||
<string name="retry">Retry</string> | |||
<string name="update_wear">Update Wear Theme</string> | |||
<string name="sign_in_for_bookmarks">In order to save your bookmarks, you\'ll need to sign in.</string> | |||
<string name="sign_in_for_bookmarks">In order to save your bookmarks, you'll need to sign in.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this one works without the \
but the other one needs it...
@martinbonnin @joreilly here are some related issues:
that brings up the question of why are we trying to mirror string resources in It seems like resources that are directly used in the shared module can't be modified by regular Android string resources. What do you think about declaring those only in the shared module (with the <resources>
<string name="sessions">Sessions</string>
<string name="oops">Oops something went wrong</string>
<string name="retry">Retry</string>
<string name="sign_in_for_bookmarks">In order to save your bookmarks, you'll need to sign in.</string>
<string name="cancel">CANCEL</string>
<string name="sign_in">SIGN IN</string>
</resources> |
Hmm, I think I might have been in process of transitioning those strings to shared code which is why they're probably still duplicated. Will take a look soon at cleaning that up. |