CI: opt-in gradle-home-cache-cleanup: true #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Mar 17, 2023
| @@ -22,6 +22,8 @@ jobs: | |||
|
|
|||
| - name: Setup Gradle | |||
| uses: gradle/gradle-build-action@v2 | |||
| with: | |||
| gradle-home-cache-cleanup: true | |||
There was a problem hiding this comment.
I think this is the only one that actually runs on main.
There was a problem hiding this comment.
Makes sense. That also means if a PR workflow uses a big dependency, the next MAIN workflow will most likely delete it because it wasn't used during the run. I think that's acceptable as MAIN should do most of the work. Anyways, I'll remove the other ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% clear where the good place to put this is. Looks like the
gradle-build-actionconfig and cache key is global to the workflow so putting it in the initial setup is the correct place but maybe it needs to be in the last one, not 100% sure.See also gradle/actions#26