Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Messenger as command bus #73

Closed
wants to merge 5 commits into from

Conversation

Lutacon
Copy link
Collaborator

@Lutacon Lutacon commented Aug 29, 2018

Initial integration to use Messenger as command bus and also to remove tactician and rabbit bundle dependency ;)

  • Create new command buses
  • Remove tactician dependency
  • Create new transport
  • Remove Old Sound RabbitMQ bundle dependency.

@Lutacon Lutacon added the WIP label Aug 29, 2018
@Lutacon Lutacon force-pushed the new_command_bus branch 2 times, most recently from 6f2fc94 to aace346 Compare August 29, 2018 13:04
@Lutacon Lutacon requested a review from jorge07 August 29, 2018 13:04
@coveralls
Copy link

coveralls commented Aug 29, 2018

Pull Request Test Coverage Report for Build 244

  • 8 of 9 (88.89%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.611%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/UI/Http/Web/Controller/AbstractRenderController.php 1 2 50.0%
Totals Coverage Status
Change from base Build 239: 0.0%
Covered Lines: 501
Relevant Lines: 524

💛 - Coveralls

config/services.yaml Outdated Show resolved Hide resolved
@Lutacon Lutacon force-pushed the new_command_bus branch 2 times, most recently from 2e58154 to 9b7b1f6 Compare August 30, 2018 15:37
.env.dist Outdated Show resolved Hide resolved
etc/deploy/Dockerfile Outdated Show resolved Hide resolved
@jorge07
Copy link
Owner

jorge07 commented Sep 23, 2018

Help wanted?

@Lutacon
Copy link
Collaborator Author

Lutacon commented Oct 3, 2018

I was on vacation 😃 I hope to finish it this weekend. If I'm not able to finish last part I'm going to ask for your help

@karael
Copy link

karael commented Oct 26, 2018

Hi,
Takes care of messenger component it's not stable yet (last estimation was sf 4.3)
also they are some usefull bundle like:
https://github.com/php-enqueue/messenger-adapter
https://github.com/php-enqueue/enqueue-bundle
they respect Queue Interoperability and AMQP

@jorge07
Copy link
Owner

jorge07 commented Dec 16, 2018

Any update on this @Lutacon? Any help wanted?

@Lutacon
Copy link
Collaborator Author

Lutacon commented Dec 17, 2018

Let me see what I've got and maybe you can help me finish it.

@db306
Copy link

db306 commented Feb 2, 2019

Hi, I'm wondering if this is still something up to date given the discussion here seems like this is not implemented anymore ?

@jorge07
Copy link
Owner

jorge07 commented Feb 2, 2019

It is. This will help to replace tactician and rabbitmq bundle. I really want to see this working.

@karael
Copy link

karael commented Feb 4, 2019

So what's up ? I have some time to help

@jorge07
Copy link
Owner

jorge07 commented Feb 27, 2019

@Lutacon I'll try myself this weekend this migration in a separated branch just to play. Any advice?

@Lutacon
Copy link
Collaborator Author

Lutacon commented Feb 27, 2019

I have a problem with the serialization of the User, the Credentials VO is not being serialized. Tbh I didn't have much time to debug it.

Also, the messenger component changes a lot between 4.1 and 4.2

@waeyy
Copy link

waeyy commented Jul 31, 2019

Hi,

Any news concerning the implementation of Messenger as command bus ?

@db306
Copy link

db306 commented Jul 31, 2019

I’m starting to work on it this week at work, it should technically be an interface implementation from the application layer on to infrastructure. I built it on Tactician at first should be able to translate it to messenger pretty easily.

@jorge07
Copy link
Owner

jorge07 commented Feb 7, 2020

@Lutacon closing in favour of #132 ;)

@jorge07 jorge07 closed this Feb 7, 2020
@Lutacon Lutacon deleted the new_command_bus branch February 10, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants