Unicode filename support fixing #203 #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eh, tests fail because python 2.6 is tested and the project dependencies fail to install. Can we please switch off travis-ci testing in python 2.6? |
|
Hmmm, root-cause was Pillow > 4.0.0 dropped python 2.6 support. So either drop python 2.6 in this library or set dependency pillow < 4.0.0 . See https://pillow.readthedocs.io/en/4.3.x/installation.html#notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-ascii files raise errors, see #203 . On Mac it's more complex because the unicode filenames we read with
os.walk()contain different codepoints for the same unicode characters we wrote (https://stackoverflow.com/a/33647372/193886 pointed me in the right direction,unicodedata.normalize()is your friend).