Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kleur and kleur’s author mention to docs as inspiration #79

Closed
ai opened this issue Sep 26, 2021 · 5 comments
Closed

Add kleur and kleur’s author mention to docs as inspiration #79

ai opened this issue Sep 26, 2021 · 5 comments

Comments

@ai
Copy link
Contributor

ai commented Sep 26, 2021

It seems like the idea of color functions export was copied from kleur:

  1. 9 Jul 2018 in kleur: lukeed/kleur@41e4696
  2. 11 Jul 2018 in colorette: 0226f47

You should give honor to kleur author and mention him in docs.

@jorgebucaran
Copy link
Owner

I encourage everyone to go through the git history both ways. There was cross-pollination (from both sides). I said it.

These commits go back to when the project was named Clorox, and we still used the familiar chalk-like prototype-based API. Colorette, in its current incarnation, was realized after I switched away from prototypes, at which point it had nothing to do with kleur or chalk, implementation-wise.

@ai
Copy link
Contributor Author

ai commented Sep 26, 2021

Cross-pollination still mean that you need to mention kleur

@jorgebucaran
Copy link
Owner

You are missing the point. Colorette doesn't use prototypes anymore. It used to. Back then, it also had a different name and it even had a different home in npm. kleur was also prototype-based at the time.

I wouldn't expect kleur to mention Colorette either since its API is entirely different. Both our APIs and implementation have diverged beyond recognition. The only thing we have in common now is that we both colorize terminal text.

@ai
Copy link
Contributor Author

ai commented Sep 26, 2021

I am talking about color functions export like let { red } = require(x). Seems like in kleur this API was 3 days before the Colorette.

@jorgebucaran
Copy link
Owner

That's not how kleur API works at all.

kleur.blue().bold().underline("foo") // kleur
blue(bold(underline("foo"))) // Colorette

I introduced the current API here. At that point, kleur and Colorette no longer resembled each other. Also, keep in mind that the previous incarnation of Colorette predates kleur several years.

Repository owner locked as resolved and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants