Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better help for failed installs #24

Closed
ghost opened this issue Jan 6, 2016 · 3 comments
Closed

Better help for failed installs #24

ghost opened this issue Jan 6, 2016 · 3 comments
Labels
outdated Forgotten lore
Milestone
0.3.0

Comments

@ghost
Copy link

ghost commented Jan 6, 2016

If Fisherman fails to install a package it could offer better help adding something like:

Did you miss the `prefix-` or `theme-`?

In the case of oh-my-fish plugins, or even better, if it fails, then test with plugin- and if that fails too, test theme-.

Another thing, it should validate ohm-y-fish, o-hm-y-fsh or similar looking URLs to the correct address.
@ghost ghost added the feature label Jan 6, 2016
@L4570N3
Copy link

L4570N3 commented Jan 7, 2016

I agree with this i wanted to recommend the same..

@ghost
Copy link
Author

ghost commented Jan 7, 2016

Thanks! Noted.

@ghost ghost added this to the 0.3.0 milestone Jan 7, 2016
@ghost ghost mentioned this issue Jan 7, 2016
Merged
@ghost
Copy link
Author

ghost commented Jan 7, 2016

@namandistro Please upgrade to 0.3.0! ⚓

@ghost ghost closed this as completed Jan 7, 2016
ghost pushed a commit that referenced this issue Jan 10, 2016
Ahoy! Fisherman gets a super patch v0.3.1
ffd466b 
This patch contains several amends for 0.3.0 and
other minor documentation corrections.  Major
documentation revision and rewrite.

fisher help shows fisher(1) by default now.

Fix a critical bug that was causing fisher uninstall
--force to remove not the symbolic link, but the
actual files. Closes #24

Rename orphan tag to custom for plugins installed
using a custom URL.

warning Remove fisher --link flag and create symbolic
links by default for local paths. The user does not
have to worry about symbolic links or whether the
copy is as symbolic link or not anymore. If the user
tries to install a local path, then the best thing
to do is to create a symbolic link. This also
eliminates the need to call update.

warning Remove fisher --cache and fisher --validate.
Now, that these options are separated into their own
function and they are intentionally private, there
is no need for them.
ghost pushed a commit that referenced this issue Jan 10, 2016
Ahoy! Fisherman gets a super patch v0.3.1
7078552 
This patch contains several amends for 0.3.0 and
other minor documentation corrections.  Major
documentation revision and rewrite.

fisher help shows fisher(1) by default now.

Fix a critical bug that was causing fisher uninstall
--force to remove not the symbolic link, but the
actual files. Closes #24

Rename orphan tag to custom for plugins installed
using a custom URL.

warning Remove fisher --link flag and create symbolic
links by default for local paths. The user does not
have to worry about symbolic links or whether the
copy is as symbolic link or not anymore. If the user
tries to install a local path, then the best thing
to do is to create a symbolic link. This also
eliminates the need to call update.

warning Remove fisher --cache and fisher --validate.
Now, that these options are separated into their own
function and they are intentionally private, there
is no need for them.
@ghost ghost mentioned this issue Jan 10, 2016
Merged
jorgebucaran pushed a commit that referenced this issue Sep 21, 2016
@jojibucaran
Ahoy! Fisherman gets a super patch v0.3.1
cf4cdd9 
This patch contains several amends for 0.3.0 and
other minor documentation corrections.  Major
documentation revision and rewrite.

fisher help shows fisher(1) by default now.

Fix a critical bug that was causing fisher uninstall
--force to remove not the symbolic link, but the
actual files. Closes #24

Rename orphan tag to custom for plugins installed
using a custom URL.

warning Remove fisher --link flag and create symbolic
links by default for local paths. The user does not
have to worry about symbolic links or whether the
copy is as symbolic link or not anymore. If the user
tries to install a local path, then the best thing
to do is to create a symbolic link. This also
eliminates the need to call update.

warning Remove fisher --cache and fisher --validate.
Now, that these options are separated into their own
function and they are intentionally private, there
is no need for them.
jorgebucaran added a commit that referenced this issue Sep 7, 2018
@jorgebucaran
Ahoy! Fisherman gets a super patch v0.3.1
ee0338d 
This patch contains several amends for 0.3.0 and
other minor documentation corrections.  Major
documentation revision and rewrite.

fisher help shows fisher(1) by default now.

Fix a critical bug that was causing fisher uninstall
--force to remove not the symbolic link, but the
actual files. Closes #24

Rename orphan tag to custom for plugins installed
using a custom URL.

warning Remove fisher --link flag and create symbolic
links by default for local paths. The user does not
have to worry about symbolic links or whether the
copy is as symbolic link or not anymore. If the user
tries to install a local path, then the best thing
to do is to create a symbolic link. This also
eliminates the need to call update.

warning Remove fisher --cache and fisher --validate.
Now, that these options are separated into their own
function and they are intentionally private, there
is no need for them.
@jorgebucaran jorgebucaran added the outdated Forgotten lore label Sep 12, 2018
Repository owner locked and limited conversation to collaborators Sep 12, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated Forgotten lore
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@jorgebucaran @L4570N3