Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the - stdio symbol #31

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Conversation

jridgewell
Copy link
Contributor

- by itself is not a flag, but an operand.

`-` by itself is not a flag, but an operand.
@codecov-io
Copy link

codecov-io commented Nov 11, 2017

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #31   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          64     64           
=====================================
  Hits           64     64
Impacted Files Coverage Δ
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a855bec...4df0082. Read the comment docs.

@jorgebucaran jorgebucaran merged commit 8bfb1f5 into jorgebucaran:master Nov 11, 2017
@jorgebucaran
Copy link
Owner

Nice catch! 👍

if ("-" === arg[1]) {
var end = arg.indexOf("=")
var end = arg.indexOf("=", 2)
Copy link
Owner

@jorgebucaran jorgebucaran Nov 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jridgewell Unrelated to the feature, but such a lovely zepto optimization. 😄

@jridgewell jridgewell deleted the handle- branch November 11, 2017 04:11
jorgebucaran pushed a commit that referenced this pull request Jan 6, 2018
`-` by itself is not a flag, but an operand.
jorgebucaran pushed a commit that referenced this pull request Jan 7, 2018
`-` by itself is not a flag, but an operand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants