Falsey attributes

jorgebucaran · Mar 8, 2018 · a02b0d9 · a02b0d9
1 parent c1be5bd
commit a02b0d9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -161,7 +161,7 @@ export function app(state, actions, view, container) {
           element.removeEventListener(name, eventListener)
         }
       } else if (name in element && name !== "list" && !isSvg) {
-        element[name] = value == null ? "" : value
+        element[name] = value == null || value === "false" ? "" : value
       } else if (value != null && value !== false) {
         element.setAttribute(name, value)
       }

diff --git a/test/dom.test.js b/test/dom.test.js
@@ -652,3 +652,10 @@ testVdomToHtml("events", [
     html: `<button id="clicked"></button>`
   }
 ])
+
+testVdomToHtml("falsey attributes", [
+  {
+    vdom: <input spellcheck="false" draggable={false} />,
+    html: `<input spellcheck="false">`
+  }
+])