Falsey attributes

jorgebucaran · Mar 16, 2018 · b8fef98 · b8fef98
1 parent cf041a6
commit b8fef98
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/hyperapp.d.ts b/hyperapp.d.ts
@@ -24,7 +24,7 @@ export interface Component<Attributes = {}> {
 /**
  * Possibles children types
  */
-export type Children = VNode | string | number | null;
+export type Children = VNode | string | number | null
 
 /** The soft way to create a VNode.
  * @param name      An element name or a Component function
@@ -37,7 +37,7 @@ export type Children = VNode | string | number | null;
 export function h<Attributes>(
   nodeName: Component<Attributes> | string,
   attributes?: Attributes,
-  ...children: Array<Children | Children[]>,
+  ...children: Array<Children | Children[]>
 ): VNode<Attributes>
 
 /** @namespace [App] */

diff --git a/src/index.js b/src/index.js
@@ -166,7 +166,13 @@ export function app(state, actions, view, container) {
           element.removeEventListener(name, eventListener)
         }
       } else if (name in element && name !== "list" && !isSvg) {
-        element[name] = value == null ? "" : value
+        element[name] =
+          value == null ||
+          value === "false" ||
+          value === "off" ||
+          value === "no"
+            ? ""
+            : value
       } else if (value != null && value !== false) {
         element.setAttribute(name, value)
       }

diff --git a/test/dom.test.js b/test/dom.test.js
@@ -652,3 +652,10 @@ testVdomToHtml("events", [
     html: `<button id="clicked"></button>`
   }
 ])
+
+testVdomToHtml("falsey attributes", [
+  {
+    vdom: <input spellcheck="false" autocomplete="off" translate="no" />,
+    html: `<input spellcheck="false" autocomplete="off" translate="no">`
+  }
+])