Falsey attributes

jorgebucaran · Mar 1, 2018 · ee94ef1 · ee94ef1
1 parent a6eec2b
commit ee94ef1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -153,7 +153,7 @@ export function app(state, actions, view, container) {
         typeof value === "function" ||
         (name in element && name !== "list" && !isSVG)
       ) {
-        element[name] = value == null ? "" : value
+        element[name] = value == null || value === "false" ? "" : value
       } else if (value != null && value !== false) {
         element.setAttribute(name, value)
       }

diff --git a/test/dom.test.js b/test/dom.test.js
@@ -767,3 +767,13 @@ testTreeSegue("input list attribute", [
     html: `<input list="foobar">`
   }
 ])
+
+testTreeSegue("falsey attributes", [
+  {
+    tree: h("input", {
+      spellcheck: "false",
+      draggable: "false"
+    }),
+    html: `<input spellcheck="false" draggable="false">`
+  }
+])