Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Bax to Replay #11

Closed
jorgebucaran opened this issue Dec 6, 2020 · 5 comments
Closed

Rename Bax to Replay #11

jorgebucaran opened this issue Dec 6, 2020 · 5 comments
Labels
meta News and communication

Comments

@jorgebucaran
Copy link
Owner

Replay is more clear about what this tool does. Bax isn't. That's the only reason. Fisher 4.x makes the transition easy too:

fisher remove jorgebucaran/bax.fish && fisher install jorgebucaran/replay.fish
@jorgebucaran jorgebucaran added the meta News and communication label Dec 6, 2020
@jorgebucaran jorgebucaran pinned this issue Dec 6, 2020
@tsdh
Copy link

tsdh commented Dec 6, 2020

The transition is easy if you know about it. If not, you have to invest some time to figure out why your environment is broken. Keep in mind, bax/replay is quite a mission critical utility if you use fish as login shell.

A good strategy for the rename would have been to keep a bax script which just calls replay and also issues a big fat deprecation warning.

@jorgebucaran
Copy link
Owner Author

Hey, @tsdh. Did you run into any issues?

@tsdh
Copy link

tsdh commented Dec 7, 2020

@jorgebucaran Yes, a bit, because I run things like bax source /etc/profile; bax source ~/.profile in my ~/.config/fish/conf.d/02_env.fish to setup my environment. Those failed after the rename because the bax function was gone. Of course, the error messages pointed in the right direction so I've come here and could read about the rename.

But even those 10 minutes could have been an annoyance if I had needed a working system right now. (Ok, of course, just don't do an update just before something important. ;-))

So no big deal. Thanks for the great utility!

@jorgebucaran
Copy link
Owner Author

jorgebucaran commented Dec 7, 2020

No, you're totally right. One can do a lot in 10 minutes and I could've handled the transition more gracefully. So, bax.fish is back with a deprecation warning. ef48543

I'll get rid of it eventually, but it stays for now to ease the transition. Thank you!

@tsdh
Copy link

tsdh commented Dec 7, 2020

@jorgebucaran Yeah, that's exactly what I've had in mind, and of course it can be removed again within a reasonable time frame. Thank!

@jorgebucaran jorgebucaran unpinned this issue Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta News and communication
Projects
None yet
Development

No branches or pull requests

2 participants