Corrected description of remove #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per closing of #82 this needs to accurately describe how it currently works.
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 119 119
Branches 38 38
=====================================
Hits 119 119Continue to review full report at Codecov.
|
jorgebucaran
requested changes
Jan 9, 2018
| @@ -133,7 +133,7 @@ Fired after the element is created and attached to the DOM. | |||
|
|
|||
| #### `onupdate` | |||
|
|
|||
| Fired after the element attributes are updated. This event will fire even if the attributes have not changed. | |||
| Fired after the existing element is updated. This event does *not* fire with `oncreate`, but *will* fire during element updates, regardless of whether any attributes have actually changed. | |||
There was a problem hiding this comment.
Fired after the existing element is updated. This event will fire even if the attributes have not changed.
There was a problem hiding this comment.
I don't understand? You're just quoting the original text?
The point was to clarify the fact that oncreate and onupdate are mutually exclusive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per closing of #82 this needs to accurately describe how it currently works.