Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Commit

Permalink
Improved read performance (#1124)
Browse files Browse the repository at this point in the history
  • Loading branch information
jorgecarleitao committed Jun 29, 2022
1 parent 3c49124 commit 81ab424
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 6 deletions.
6 changes: 6 additions & 0 deletions src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ impl From<simdutf8::basic::Utf8Error> for Error {
}
}

impl From<std::collections::TryReserveError> for Error {
fn from(_: std::collections::TryReserveError) -> Error {
Error::Overflow
}
}

impl Display for Error {
fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
match self {
Expand Down
19 changes: 13 additions & 6 deletions src/io/parquet/read/row_group.rs
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,15 @@ fn _read_single_column<'a, R>(
where
R: Read + Seek,
{
let (start, len) = meta.byte_range();
let (start, length) = meta.byte_range();
reader.seek(std::io::SeekFrom::Start(start))?;
let mut chunk = vec![0; len as usize];
reader.read_exact(&mut chunk)?;

let mut chunk = vec![];
chunk.try_reserve(length as usize)?;
reader
.by_ref()
.take(length as u64)
.read_to_end(&mut chunk)?;
Ok((meta, chunk))
}

Expand All @@ -136,10 +141,12 @@ where
F: Fn() -> BoxFuture<'b, std::io::Result<R>>,
{
let mut reader = factory().await?;
let (start, len) = meta.byte_range();
let (start, length) = meta.byte_range();
reader.seek(std::io::SeekFrom::Start(start)).await?;
let mut chunk = vec![0; len as usize];
reader.read_exact(&mut chunk).await?;

let mut chunk = vec![];
chunk.try_reserve(length as usize)?;
reader.take(length as u64).read_to_end(&mut chunk).await?;
Result::Ok((meta, chunk))
}

Expand Down

0 comments on commit 81ab424

Please sign in to comment.