More fixes

jorgecarleitao · Dec 18, 2022 · ad4358f · ad4358f
1 parent 89e9aed
commit ad4358f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/compute/utf8.rs b/src/compute/utf8.rs
@@ -8,7 +8,7 @@ use crate::{
 };
 
 /// utf8_apply will apply `Fn(&str) -> String` to every value in Utf8Array.
-pub fn utf8_apply<O: Offset, F: Fn(&str) -> String>(f: F, array: &Utf8Array<O>) -> Utf8Array<O> {
+pub fn utf8_apply<O: Offset, F: Fn(&str) -> &str>(f: F, array: &Utf8Array<O>) -> Utf8Array<O> {
     let iter = array.values_iter().map(f);
 
     let new = Utf8Array::<O>::from_trusted_len_values_iter(iter);

diff --git a/tests/it/compute/substring.rs b/tests/it/compute/substring.rs
@@ -42,12 +42,12 @@ fn with_nulls_utf8<O: Offset>() -> Result<()> {
     cases
         .into_iter()
         .try_for_each::<_, Result<()>>(|(array, start, length, expected)| {
-            let array = Utf8Array::<O>::from(&array);
+            let array = Utf8Array::<O>::from(array);
             let result = substring(&array, start, &length)?;
             assert_eq!(array.len(), result.len());
 
             let result = result.as_any().downcast_ref::<Utf8Array<O>>().unwrap();
-            let expected = Utf8Array::<O>::from(&expected);
+            let expected = Utf8Array::<O>::from(expected);
 
             assert_eq!(&expected, result);
             Ok(())
@@ -194,12 +194,12 @@ fn with_null_binarys<O: Offset>() -> Result<()> {
     cases
         .into_iter()
         .try_for_each::<_, Result<()>>(|(array, start, length, expected)| {
-            let array = BinaryArray::<O>::from(&array);
+            let array = BinaryArray::<O>::from(array);
             let result = substring(&array, start, &length)?;
             assert_eq!(array.len(), result.len());
 
             let result = result.as_any().downcast_ref::<BinaryArray<O>>().unwrap();
-            let expected = BinaryArray::<O>::from(&expected);
+            let expected = BinaryArray::<O>::from(expected);
             assert_eq!(&expected, result);
             Ok(())
         })?;
@@ -274,11 +274,11 @@ fn without_null_binarys<O: Offset>() -> Result<()> {
     cases
         .into_iter()
         .try_for_each::<_, Result<()>>(|(array, start, length, expected)| {
-            let array = BinaryArray::<O>::from_slice(&array);
+            let array = BinaryArray::<O>::from_slice(array);
             let result = substring(&array, start, &length)?;
             assert_eq!(array.len(), result.len());
             let result = result.as_any().downcast_ref::<BinaryArray<O>>().unwrap();
-            let expected = BinaryArray::<O>::from_slice(&expected);
+            let expected = BinaryArray::<O>::from_slice(expected);
             assert_eq!(&expected, result);
             Ok(())
         })?;