Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Expose share counts in Buffer #1072

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

ritchie46
Copy link
Collaborator

For polars extension types' dark unsafe magic I need to know how often underlying data is shared. This was possible when we Arced the arrays.

This exposes a method to get the shared count of the Buffer's data.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1072 (3b83764) into main (83082fa) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   81.02%   81.01%   -0.02%     
==========================================
  Files         366      366              
  Lines       35050    35056       +6     
==========================================
  Hits        28399    28399              
- Misses       6651     6657       +6     
Impacted Files Coverage Δ
src/buffer/immutable.rs 88.88% <0.00%> (-7.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83082fa...3b83764. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title buffer share counts Expose share counts in Buffer Jun 14, 2022
@jorgecarleitao jorgecarleitao merged commit 72df09f into jorgecarleitao:main Jun 14, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants