Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed panic in writing dictionaries to parquet #1113

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Fixed panic in writing dictionaries to parquet #1113

merged 3 commits into from
Jun 28, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Jun 27, 2022

Also added tests covering them (and others)

@jorgecarleitao jorgecarleitao added the testing PRs that only increase coverage label Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1113 (ee91956) into main (b942a84) will increase coverage by 0.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
+ Coverage   81.33%   82.08%   +0.75%     
==========================================
  Files         367      367              
  Lines       35458    35836     +378     
==========================================
+ Hits        28840    29417     +577     
+ Misses       6618     6419     -199     
Impacted Files Coverage Δ
src/io/parquet/read/deserialize/simple.rs 69.73% <100.00%> (+14.82%) ⬆️
src/io/parquet/write/dictionary.rs 85.41% <100.00%> (+4.16%) ⬆️
src/io/parquet/read/deserialize/boolean/basic.rs 93.41% <0.00%> (-1.08%) ⬇️
...rc/io/parquet/read/deserialize/primitive/nested.rs 87.96% <0.00%> (-0.27%) ⬇️
src/io/parquet/read/deserialize/nested_utils.rs 83.71% <0.00%> (-0.23%) ⬇️
src/io/ipc/read/reader.rs 96.02% <0.00%> (ø)
src/array/utf8/mod.rs 91.07% <0.00%> (+0.27%) ⬆️
src/array/fixed_size_binary/mod.rs 88.00% <0.00%> (+0.50%) ⬆️
src/io/parquet/read/deserialize/boolean/nested.rs 68.10% <0.00%> (+1.04%) ⬆️
src/array/binary/mod.rs 90.12% <0.00%> (+1.23%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b942a84...ee91956. Read the comment docs.

@jorgecarleitao jorgecarleitao added bug Something isn't working and removed testing PRs that only increase coverage labels Jun 27, 2022
@jorgecarleitao jorgecarleitao changed the title Added more tests for roundtrip of dicts over parquet Fixed edge cases in writing dictionaries to parquet Jun 27, 2022
@jorgecarleitao jorgecarleitao changed the title Fixed edge cases in writing dictionaries to parquet Fixed panic in writing dictionaries to parquet Jun 27, 2022
@jorgecarleitao jorgecarleitao merged commit b522364 into main Jun 28, 2022
@jorgecarleitao jorgecarleitao deleted the tests1 branch June 28, 2022 00:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant