Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Moved Bytes to own crate #1141

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Moved Bytes to own crate #1141

merged 1 commit into from
Jul 11, 2022

Conversation

jorgecarleitao
Copy link
Owner

This PR proposes that we move the Bytes API to another crate so others can use it without having to copy paste. It also separates concerns between this crate (arrow) and a mechanism to use share foreign arrays with Rust still compatible with mutable APIs.

Proposed home: https://github.com/DataEngineeringLabs/foreign_vec

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #1141 (0fc0182) into main (98e4913) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
- Coverage   83.59%   83.59%   -0.01%     
==========================================
  Files         366      365       -1     
  Lines       35901    35851      -50     
==========================================
- Hits        30013    29970      -43     
+ Misses       5888     5881       -7     
Impacted Files Coverage Δ
src/array/ffi.rs 86.95% <ø> (ø)
src/array/map/ffi.rs 0.00% <0.00%> (ø)
src/array/null.rs 45.67% <0.00%> (ø)
src/array/union/ffi.rs 0.00% <ø> (ø)
src/array/binary/ffi.rs 97.50% <100.00%> (ø)
src/array/boolean/ffi.rs 97.14% <100.00%> (ø)
src/array/dictionary/ffi.rs 70.83% <100.00%> (ø)
src/array/fixed_size_binary/ffi.rs 97.22% <100.00%> (ø)
src/array/fixed_size_list/ffi.rs 87.50% <100.00%> (ø)
src/array/list/ffi.rs 97.56% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e4913...0fc0182. Read the comment docs.

@jorgecarleitao
Copy link
Owner Author

cc @jhorstmann @ritchie46 , since both also contributed to this component (either here or in arrow-rs).

@jorgecarleitao jorgecarleitao marked this pull request as ready for review July 7, 2022 05:48
@ritchie46
Copy link
Collaborator

LGTM. 👍

@jorgecarleitao jorgecarleitao changed the title [Proposal] Move Bytes to own crate Moved Bytes to own crate Jul 9, 2022
@jorgecarleitao jorgecarleitao merged commit 1cd7453 into main Jul 11, 2022
@jorgecarleitao jorgecarleitao deleted the moved branch July 11, 2022 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants