Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed casting dictionary keys #1143

Merged
merged 4 commits into from Jul 9, 2022

Conversation

ritchie46
Copy link
Collaborator

Updating arrow2 had some failed test in polars. It turned out that casting dictionary keys was a no-op. This PR fixes that and adds a test.

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #1143 (a59396b) into main (98e4913) will increase coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
+ Coverage   83.59%   83.63%   +0.03%     
==========================================
  Files         366      366              
  Lines       35901    35912      +11     
==========================================
+ Hits        30013    30035      +22     
+ Misses       5888     5877      -11     
Impacted Files Coverage Δ
src/compute/cast/dictionary_to.rs 26.49% <50.00%> (+4.08%) ⬆️
src/chunk.rs 83.33% <0.00%> (-7.15%) ⬇️
src/io/ipc/read/reader.rs 95.98% <0.00%> (-0.67%) ⬇️
src/io/ipc/read/schema.rs 94.56% <0.00%> (-0.32%) ⬇️
src/array/growable/utf8.rs 95.89% <0.00%> (-0.06%) ⬇️
src/io/csv/utils.rs 85.29% <0.00%> (ø)
src/array/growable/list.rs 97.14% <0.00%> (ø)
src/compute/regex_match.rs 82.35% <0.00%> (ø)
src/io/avro/read/header.rs 100.00% <0.00%> (ø)
src/io/avro/write/header.rs 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e4913...a59396b. Read the comment docs.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Jul 8, 2022
Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks a lot, @ritchie46 !

Left minor suggestions to guide readability of unsafe

src/compute/cast/dictionary_to.rs Outdated Show resolved Hide resolved
src/compute/cast/dictionary_to.rs Outdated Show resolved Hide resolved
src/compute/cast/dictionary_to.rs Show resolved Hide resolved
src/compute/cast/dictionary_to.rs Outdated Show resolved Hide resolved
ritchie46 and others added 3 commits July 8, 2022 18:49
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
Co-authored-by: Jorge Leitao <jorgecarleitao@gmail.com>
@jorgecarleitao jorgecarleitao merged commit ba45d55 into jorgecarleitao:main Jul 9, 2022
@jorgecarleitao jorgecarleitao changed the title fix casting dictionary keys Fixed casting dictionary keys Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants