This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added example reading Avro produced by Kafka #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
added
the
documentation
Codecov Report
@@ Coverage Diff @@
## main #1151 +/- ##
==========================================
+ Coverage 83.66% 83.72% +0.06%
==========================================
Files 366 366
Lines 35912 35931 +19
==========================================
+ Hits 30044 30082 +38
+ Misses 5868 5849 -19
Continue to review full report at Codecov.
|
jorgecarleitao
changed the title
scimas
reviewed
Jul 12, 2022
| "Avro requires the first byte to be a zero".to_string(), | ||
| )); | ||
| } | ||
| Ok(i32::from_be_bytes(header[1..].try_into().unwrap())) |
There was a problem hiding this comment.
I see that this is already merged, but I would suggest changing this to u32 instead of i32.
I don't know where the specification for the schema_id is, but the API documentation for Confluent's schema registry specifies that version (schema_id) should be in the range [1, 2^31 - 1].
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka uses the single object representation of Avro. This PR adds an example showing how to read such stream.
This emerged from a question by scimas at rust users: https://users.rust-lang.org/t/status-of-avro-in-rust/78086/6