Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Removed un-needed indirection #1153

Merged
merged 1 commit into from Jul 12, 2022
Merged

Removed un-needed indirection #1153

merged 1 commit into from Jul 12, 2022

Conversation

jorgecarleitao
Copy link
Owner

Essentially replaced Box<InternalArrowArray> by InternalArrowArray, since the box was not needed.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jul 11, 2022
@ritchie46
Copy link
Collaborator

Nice catch ❤️

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1153 (82b2397) into main (1cd7453) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1153   +/-   ##
=======================================
  Coverage   83.67%   83.67%           
=======================================
  Files         365      365           
  Lines       35869    35865    -4     
=======================================
- Hits        30012    30010    -2     
+ Misses       5857     5855    -2     
Impacted Files Coverage Δ
src/ffi/array.rs 89.53% <100.00%> (-0.15%) ⬇️
src/array/utf8/mod.rs 85.62% <0.00%> (-0.96%) ⬇️
src/io/ipc/read/common.rs 94.92% <0.00%> (-0.40%) ⬇️
src/io/ipc/read/reader.rs 96.98% <0.00%> (+1.00%) ⬆️
src/array/binary/mod.rs 90.12% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd7453...82b2397. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 735218b into main Jul 12, 2022
@jorgecarleitao jorgecarleitao deleted the rm_indirection branch July 12, 2022 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants