Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added MutableUtf8Array::into_data #1170

Merged
merged 1 commit into from Jul 19, 2022

Conversation

ritchie46
Copy link
Collaborator

Similar to already existing implementations on MutablePrimitive and MutableStruct.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1170 (e7f61ee) into main (3fdb33f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
- Coverage   83.73%   83.73%   -0.01%     
==========================================
  Files         365      365              
  Lines       35847    35850       +3     
==========================================
+ Hits        30018    30019       +1     
- Misses       5829     5831       +2     
Impacted Files Coverage Δ
src/array/utf8/mutable.rs 89.77% <0.00%> (-0.76%) ⬇️
src/io/ipc/read/array/boolean.rs 90.74% <0.00%> (-7.41%) ⬇️
src/io/ipc/read/reader.rs 96.32% <0.00%> (+0.33%) ⬆️
src/io/ipc/read/file_async.rs 61.19% <0.00%> (+0.74%) ⬆️
src/io/ipc/read/stream_async.rs 76.71% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fdb33f...e7f61ee. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 3382559 into jorgecarleitao:main Jul 19, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jul 19, 2022
@jorgecarleitao jorgecarleitao changed the title implement MutableUtf8Array::into_data Added MutableUtf8Array::into_data Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants