Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Bumped to latest nightly #1186

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Bumped to latest nightly #1186

merged 2 commits into from
Jul 26, 2022

Conversation

gyscos
Copy link
Contributor

@gyscos gyscos commented Jul 25, 2022

Fixes #1184

@gyscos
Copy link
Contributor Author

gyscos commented Jul 25, 2022

Might need to ensure CI runs a very recent nightly - the PR in rustc was merged around July 22nd, so anything older than a couple of days would not work.

CI failed as expected in a run using a nightly from March:

nightly-2022-03-16-x86_64-unknown-linux-gnu installed - rustc 1.61.0-nightly (52b34550a 2022-03-15)

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1186 (aa5b641) into main (5c745f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1186   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files         364      364           
  Lines       36392    36392           
=======================================
  Hits        30381    30381           
  Misses       6011     6011           
Impacted Files Coverage Δ
src/array/utf8/mod.rs 82.71% <0.00%> (-0.93%) ⬇️
src/io/ipc/read/schema.rs 95.49% <0.00%> (-0.33%) ⬇️
src/io/ipc/read/reader.rs 96.98% <0.00%> (+0.66%) ⬆️
src/io/ipc/read/file_async.rs 61.19% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c745f4...aa5b641. Read the comment docs.

@gyscos
Copy link
Contributor Author

gyscos commented Jul 25, 2022

Added a commit to bump the nightly version used for the SIMD test.

@jorgecarleitao
Copy link
Owner

Awesome, thanks a lot, @gyscos !

@jorgecarleitao jorgecarleitao merged commit 1993395 into jorgecarleitao:main Jul 26, 2022
@jorgecarleitao jorgecarleitao changed the title Use simd comparison trait from latest nightly Bumped to latest nightly Jul 26, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std::simd::Simd::lanes_eq no longer present in latest nightly
2 participants