Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for decimal 256 #1194

Merged
merged 2 commits into from
Sep 11, 2022
Merged

Added support for decimal 256 #1194

merged 2 commits into from
Sep 11, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Jul 30, 2022

Unfortunately I could not make it without adding an extra (small and no indirect dependencies) dependency, thus the draft.

It should be possible, as we basically just need implementations for

  • neg
  • cmp
  • eq
  • from(i128, i128)
  • from str
  • to str

@jorgecarleitao jorgecarleitao added the investigation Issues or PRs that are investigations. Prs may or may not be merged. label Jul 30, 2022
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #1194 (b52522b) into main (497d431) will decrease coverage by 0.19%.
The diff coverage is 30.61%.

@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
- Coverage   83.49%   83.30%   -0.20%     
==========================================
  Files         356      356              
  Lines       37081    37200     +119     
==========================================
+ Hits        30961    30989      +28     
- Misses       6120     6211      +91     
Impacted Files Coverage Δ
src/array/mod.rs 68.54% <ø> (ø)
src/array/primitive/mod.rs 81.04% <ø> (ø)
src/compute/arithmetics/mod.rs 74.10% <ø> (ø)
src/compute/comparison/mod.rs 54.07% <ø> (ø)
src/compute/comparison/simd/native.rs 88.88% <0.00%> (-5.23%) ⬇️
src/ffi/schema.rs 90.38% <0.00%> (-1.48%) ⬇️
src/io/json_integration/read/array.rs 85.59% <0.00%> (-3.90%) ⬇️
src/io/json_integration/write/schema.rs 0.00% <0.00%> (ø)
src/types/mod.rs 100.00% <ø> (ø)
src/types/simd/mod.rs 86.11% <0.00%> (-2.47%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jorgecarleitao jorgecarleitao marked this pull request as ready for review August 4, 2022 17:33
@jorgecarleitao jorgecarleitao merged commit a1ab5a7 into main Sep 11, 2022
@jorgecarleitao jorgecarleitao deleted the decimal256 branch September 11, 2022 10:52
@jorgecarleitao jorgecarleitao added backwards-incompatible and removed investigation Issues or PRs that are investigations. Prs may or may not be merged. labels Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant