Added MutableStructArray

[hohav]

Very rough initial implementation of #703. Hopefully it's at least pointing in the right direction.

[codecov]

Codecov Report

Merging #1196 (aa9af03) into main (3b9d86b) will decrease coverage by 0.17%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
- Coverage   83.48%   83.31%   -0.18%     
==========================================
  Files         356      357       +1     
  Lines       37081    37225     +144     
==========================================
+ Hits        30957    31013      +56     
- Misses       6124     6212      +88     

Impacted Files	Coverage Δ
src/array/mod.rs	68.54% <ø> (ø)
src/array/struct_/mod.rs	61.45% <ø> (ø)
src/array/struct_/mutable.rs	38.88% <38.88%> (ø)
src/bitmap/utils/slice_iterator.rs	97.56% <0.00%> (-1.22%)	⬇️
src/io/ipc/read/reader.rs	96.65% <0.00%> (+0.33%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jorgecarleitao]

Thanks a lot, @hohav . This looks great!

I agree with that we need to expose &mut A and request the user to extend based on their knowledge of the children's types.

I left minor comments related to performance and documentation, otherwise imo the design makes a lot of sense. 🙇

[jorgecarleitao]

I think we can't get away with this check :) One option we could do here is to offer a function extend_validity() that pushes multiple items into the validity at once, in case the user can/wants to avoid this check on every call.

[hohav]

Do you mean "can't get away without"?

I wouldn't use extend_validity personally, but I can add it if you think it's useful.

What about adding push_unchecked?

[jorgecarleitao]

Would you be able to rebase against main and use the reserve?

[hohav]

I rebased and updated reserve. I believe there's only one open question left, about performance of the validity check in push.

[jorgecarleitao]

Thanks a lot @hohav !