This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fix escaped like wildcards #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new function that replaces the like wildcards '%' and '_' for the regex counterparts before executing them. It also takes into account that the wildcards can be escaped, in that case, it does remove the escape characters and leaves the wildcards so that they are matched against the raw character. This is implemented iterating over all the characters of the pattern to figure out when it needs to be transformed or not.
Codecov Report
@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
- Coverage 83.44% 83.34% -0.10%
==========================================
Files 366 366
Lines 36697 36793 +96
==========================================
+ Hits 30621 30666 +45
- Misses 6076 6127 +51
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks a lot @daniel-martinez-maqueda-sap 🙇 |
jorgecarleitao
pushed a commit
that referenced
this pull request
Aug 4, 2022
|
Released as part of 0.13.1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #702
Rationale for this change
It is explained in the Issues linked above.
What changes are included in this PR?
Added a new function that replaces the like wildcards '%' and '_' for the regex counterparts before executing them. It also takes into account that the wildcards can be escaped, in that case, it does remove the escape characters and leaves the wildcards so that they are matched against the raw character.
This is implemented iterating over all the characters of the pattern to figure out when it needs to be transformed or not.
Are there any user-facing changes?
N/A