Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Simpler IPC API #1208

Merged
merged 1 commit into from Aug 8, 2022
Merged

Simpler IPC API #1208

merged 1 commit into from Aug 8, 2022

Conversation

jorgecarleitao
Copy link
Owner

This PR removes from the public API internal methods and exposes them with more intuitive APIs.

This reduces the mental load of the IPC API public surface to users, thereby allowing them to more easily use the crate.

It also makes it easier to read from flight, as all utilities to do so are now available under io::flight.

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1208 (ffcc0c2) into main (497d431) will decrease coverage by 0.16%.
The diff coverage is 72.18%.

@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
- Coverage   83.49%   83.32%   -0.17%     
==========================================
  Files         356      357       +1     
  Lines       37081    37159      +78     
==========================================
+ Hits        30961    30964       +3     
- Misses       6120     6195      +75     
Impacted Files Coverage Δ
src/io/flight/mod.rs 37.64% <0.00%> (-29.36%) ⬇️
src/io/ipc/read/file_async.rs 61.19% <ø> (ø)
src/io/ipc/read/reader.rs 94.66% <ø> (-1.32%) ⬇️
src/mmap/mod.rs 84.84% <ø> (ø)
src/io/ipc/read/file.rs 97.32% <97.32%> (ø)
src/io/ipc/read/array/boolean.rs 90.74% <0.00%> (-7.41%) ⬇️
src/bitmap/immutable.rs 86.41% <0.00%> (+0.61%) ⬆️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️
src/array/binary/mod.rs 90.12% <0.00%> (+1.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant