Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed StackOverflow in skipping many parquet row groups #1210

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

jorgecarleitao
Copy link
Owner

Closed #1206. Thanks a lot @sigurdteigen for the report!

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1210 (7405760) into main (3a828c6) will increase coverage by 0.02%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #1210      +/-   ##
==========================================
+ Coverage   83.12%   83.15%   +0.02%     
==========================================
  Files         358      358              
  Lines       37304    37297       -7     
==========================================
+ Hits        31010    31015       +5     
+ Misses       6294     6282      -12     
Impacted Files Coverage Δ
src/io/parquet/read/file.rs 87.58% <90.90%> (+3.20%) ⬆️
src/array/utf8/mod.rs 82.71% <0.00%> (-0.93%) ⬇️
src/io/ipc/read/schema.rs 95.81% <0.00%> (+0.32%) ⬆️
src/io/ipc/read/file.rs 97.32% <0.00%> (+0.44%) ⬆️
src/io/ipc/read/stream_async.rs 76.71% <0.00%> (+0.68%) ⬆️
src/io/ipc/read/file_async.rs 61.19% <0.00%> (+0.74%) ⬆️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️
src/chunk.rs 90.47% <0.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jorgecarleitao jorgecarleitao merged commit 56189bd into main Aug 8, 2022
@jorgecarleitao jorgecarleitao deleted the fix_so branch August 8, 2022 17:20
@jorgecarleitao jorgecarleitao changed the title Fixed StackOverflow in many row groups Fixed StackOverflow in skipping many parquet row groups Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack overflow in parquet RowGroupReader with groups_filter
1 participant