Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added documentation on parquet compatibility under TimeUnit. #1238

Merged
merged 1 commit into from Sep 1, 2022

Conversation

TurnOfACard
Copy link
Contributor

TimeUnit::Second will not store a logical type when converted to parquet format.

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #1238 (f93ecae) into main (c6f1427) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1238   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         359      359           
  Lines       37856    37856           
=======================================
+ Hits        31539    31540    +1     
+ Misses       6317     6316    -1     
Impacted Files Coverage Δ
src/io/parquet/write/mod.rs 86.35% <ø> (ø)
src/io/ipc/read/stream_async.rs 74.65% <0.00%> (-2.06%) ⬇️
src/io/ipc/read/file.rs 96.42% <0.00%> (-0.90%) ⬇️
src/io/ipc/read/file_async.rs 60.44% <0.00%> (-0.75%) ⬇️
src/bitmap/immutable.rs 86.41% <0.00%> (+0.61%) ⬆️
src/chunk.rs 90.47% <0.00%> (+7.14%) ⬆️
src/io/ipc/read/array/boolean.rs 98.14% <0.00%> (+7.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jorgecarleitao
Copy link
Owner

Thanks! Would it be possible to move this to io::parquet? People can use this crate without parquet :)

Basically, this is an assumption that we do when we write to to parquet, so somewhere around io::parquet::write?

@jorgecarleitao jorgecarleitao added the documentation Improvements or additions to documentation label Aug 30, 2022
`TimeUnit::Second` will not store a logical type when converted to parquet format.
@TurnOfACard
Copy link
Contributor Author

Thanks! Would it be possible to move this to io::parquet? People can use this crate without parquet :)

Basically, this is an assumption that we do when we write to to parquet, so somewhere around io::parquet::write?

A good point; I have moved it to io::parquet::write and also enumerated other types I did not originally think of as lacking logical types according to io::parquet::write::schema::to_parquet_type.

@jorgecarleitao jorgecarleitao changed the title Enhancement: Mention parquet compatibility under TimeUnit. Added documentation on parquet compatibility under TimeUnit. Sep 1, 2022
@jorgecarleitao jorgecarleitao merged commit aa2feae into jorgecarleitao:main Sep 1, 2022
@jorgecarleitao
Copy link
Owner

Thanks @TurnOfACard !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants