Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

fixed comparisson and validity kernels #1243

Merged

Conversation

ritchie46
Copy link
Collaborator

When the values masked out by the validity bits were different the comparison_and_validty kernels were incorrect. This PR fixes that.

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1243 (4c78804) into main (a7428e0) will increase coverage by 0.01%.
The diff coverage is 91.20%.

@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
+ Coverage   83.32%   83.33%   +0.01%     
==========================================
  Files         359      359              
  Lines       37854    37939      +85     
==========================================
+ Hits        31541    31618      +77     
- Misses       6313     6321       +8     
Impacted Files Coverage Δ
src/compute/boolean.rs 92.59% <85.00%> (-4.63%) ⬇️
src/compute/comparison/mod.rs 65.21% <96.07%> (+11.14%) ⬆️
src/array/utf8/mod.rs 82.71% <0.00%> (-0.93%) ⬇️
src/io/ipc/read/file.rs 97.32% <0.00%> (ø)
src/array/binary/mod.rs 90.12% <0.00%> (+1.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ritchie46 ritchie46 force-pushed the comparison_and_validity branch 2 times, most recently from 5b6ba55 to bd4700a Compare September 5, 2022 08:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants