Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Bump json_deserializer to 0.4.2 #1267

Merged

Conversation

cjermain
Copy link
Contributor

@cjermain cjermain commented Oct 4, 2022

This PR bumps json_deserializer to v0.4.2 to address the fix in jorgecarleitao/json-deserializer#14. I tested this locally against features in pola-rs/polars#3413 and confirmed the fixes are working correctly. Thanks for pushing out the release!

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 83.04% // Head: 83.05% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5d60832) compared to base (ecbc717).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1267   +/-   ##
=======================================
  Coverage   83.04%   83.05%           
=======================================
  Files         361      361           
  Lines       38370    38370           
=======================================
+ Hits        31865    31868    +3     
+ Misses       6505     6502    -3     
Impacted Files Coverage Δ
src/io/ipc/read/reader.rs 94.66% <0.00%> (-1.34%) ⬇️
src/io/ipc/read/file.rs 96.42% <0.00%> (-0.45%) ⬇️
src/io/ipc/read/file_async.rs 61.19% <0.00%> (+0.74%) ⬆️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️
src/io/ipc/read/stream_async.rs 76.71% <0.00%> (+1.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao
Copy link
Owner

Thanks!

Note that this is not necessary - cargo picks the latest version within the constraint (patch in this case); running cargo update should suffice

@jorgecarleitao jorgecarleitao merged commit 8689f71 into jorgecarleitao:main Oct 7, 2022
@cjermain
Copy link
Contributor Author

cjermain commented Oct 7, 2022

Good to know, it sounds like leaving this as 0.4 would have been sufficient to pick up the patches. Thanks!

@cjermain cjermain deleted the bump_json_deserializer branch October 7, 2022 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants