Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Improved iterators #1270

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Improved iterators #1270

merged 4 commits into from
Oct 18, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Oct 7, 2022

This improves the zipped iterators to offer iterators to:

  • the mutable counter-parts
  • into_iter of some arrays

Backwards incompatible

  • ZipValidity generic signature changed:

    • Before: ZipValidity<'a, T, I> where I: Iterator<Item = T>
    • now: ZipValidity<T, I, V> where I: Iterator<Item = T>, V: Iterator<Item = bool>
  • FixedSizeBinaryValuesIter was removed and replaced by std::slice::ChunksExact<'a,u8> since using std is always more idiomatic

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 83.05% // Head: 83.07% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5e47440) compared to base (6e46651).
Patch coverage: 88.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
+ Coverage   83.05%   83.07%   +0.01%     
==========================================
  Files         361      363       +2     
  Lines       38370    38442      +72     
==========================================
+ Hits        31868    31934      +66     
- Misses       6502     6508       +6     
Impacted Files Coverage Δ
src/array/binary/iterator.rs 100.00% <ø> (ø)
src/array/dictionary/iterator.rs 100.00% <ø> (ø)
src/array/iterator.rs 96.96% <ø> (ø)
src/array/mod.rs 68.54% <ø> (ø)
src/array/physical_binary.rs 97.67% <ø> (ø)
src/array/utf8/iterator.rs 55.55% <ø> (ø)
src/bitmap/utils/mod.rs 100.00% <ø> (ø)
src/bitmap/iterator.rs 73.52% <73.52%> (ø)
src/buffer/iterator.rs 73.52% <73.52%> (ø)
src/array/fixed_size_list/iterator.rs 66.66% <77.77%> (+6.66%) ⬆️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao merged commit 27e109d into main Oct 18, 2022
@jorgecarleitao jorgecarleitao deleted the iterators branch October 18, 2022 05:51
@jorgecarleitao jorgecarleitao added enhancement An improvement to an existing feature and removed enhancement An improvement to an existing feature labels Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant