Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added MutableBinaryValuesArray #1276

Merged
merged 1 commit into from Oct 30, 2022
Merged

Added MutableBinaryValuesArray #1276

merged 1 commit into from Oct 30, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Oct 18, 2022

This PR adds MutableBinaryValuesArray, an auxiliary struct to build non-optional binary values. This is similar to MutableUtf8ValuesArray, but without the utf8 requirement.

Backward-incompatible

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 83.05% // Head: 83.06% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c46ddb7) compared to base (6e46651).
Patch coverage: 74.48% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1276    +/-   ##
========================================
  Coverage   83.05%   83.06%            
========================================
  Files         361      364     +3     
  Lines       38370    38966   +596     
========================================
+ Hits        31868    32366   +498     
- Misses       6502     6600    +98     
Impacted Files Coverage Δ
src/array/binary/iterator.rs 75.00% <0.00%> (-25.00%) ⬇️
src/array/binary/mod.rs 91.53% <ø> (+1.30%) ⬆️
src/array/mod.rs 68.54% <ø> (ø)
src/array/specification.rs 92.39% <ø> (-0.25%) ⬇️
src/array/binary/mutable.rs 76.82% <71.42%> (-7.39%) ⬇️
src/array/binary/mutable_values.rs 75.81% <75.81%> (ø)
src/array/utf8/mutable.rs 86.22% <100.00%> (+2.39%) ⬆️
src/array/iterator.rs 95.34% <0.00%> (-1.63%) ⬇️
src/array/list/iterator.rs 66.66% <0.00%> (-0.78%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao force-pushed the mutable_binary branch 2 times, most recently from 40da2ba to 48d2d2f Compare October 21, 2022 04:30
@jorgecarleitao jorgecarleitao merged commit c9a5c3c into main Oct 30, 2022
@jorgecarleitao jorgecarleitao deleted the mutable_binary branch October 30, 2022 20:56
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added values' capacity to MutableBinaryArray::reserve
1 participant