Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Bumped arrow-format to 0.8 #1298

Merged
merged 3 commits into from
Nov 13, 2022

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Nov 13, 2022

Signed-off-by: Xuanwo github@xuanwo.io

It's required to use the same version of arrow-format for downstream.

This PR will help address issues like:

error[E0308]: mismatched types
   --> src/query/service/src/api/rpc/exchange/exchange_transform.rs:243:53
    |
243 |                     let data = FragmentData::create(values);
    |                                -------------------- ^^^^^^ expected struct `common_arrow::arrow_format::flight::data::FlightData`, found struct `arrow_format::flight::data::FlightData`
    |                                |
    |                                arguments to this function are incorrect
    |
    = note: struct `arrow_format::flight::data::FlightData` and struct `common_arrow::arrow_format::flight::data::FlightData` have similar names, but are actually distinct types
note: struct `arrow_format::flight::data::FlightData` is defined in crate `arrow_format`
   --> /home/xuanwo/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-format-0.7.0/src/flight/data.rs:202:1
    |
202 | pub struct FlightData {
    | ^^^^^^^^^^^^^^^^^^^^^
note: struct `common_arrow::arrow_format::flight::data::FlightData` is defined in crate `arrow_format`
   --> /home/xuanwo/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-format-0.8.0/src/flight/data.rs:215:1
    |
215 | pub struct FlightData {
    | ^^^^^^^^^^^^^^^^^^^^^
    = note: perhaps two different versions of crate `arrow_format` are being used?
note: associated function defined here
   --> src/query/service/src/api/rpc/packets/packet_data.rs:34:12
    |
34  |     pub fn create(data: FlightData) -> FragmentData {
    |            ^^^^^^ ----------------

Fix #1294

Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 83.10% // Head: 83.10% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d73e940) compared to base (48a5322).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1298      +/-   ##
==========================================
- Coverage   83.10%   83.10%   -0.01%     
==========================================
  Files         369      369              
  Lines       40187    40168      -19     
==========================================
- Hits        33399    33383      -16     
+ Misses       6788     6785       -3     
Impacted Files Coverage Δ
src/array/fixed_size_list/iterator.rs 60.00% <0.00%> (-6.67%) ⬇️
src/array/list/iterator.rs 32.14% <0.00%> (-6.57%) ⬇️
src/array/fixed_size_binary/iterator.rs 72.72% <0.00%> (-3.28%) ⬇️
src/array/map/iterator.rs 60.52% <0.00%> (-2.89%) ⬇️
src/array/struct_/iterator.rs 52.94% <0.00%> (-2.62%) ⬇️
src/array/boolean/mod.rs 82.71% <0.00%> (-0.24%) ⬇️
src/array/primitive/mod.rs 82.94% <0.00%> (-0.24%) ⬇️
src/array/dictionary/mod.rs 91.66% <0.00%> (-0.15%) ⬇️
src/io/json/write/serialize.rs 92.24% <0.00%> (-0.09%) ⬇️
src/array/primitive/iterator.rs 84.21% <0.00%> (+0.87%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Nov 13, 2022

Needs #1299 to make all check passed.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@jorgecarleitao jorgecarleitao changed the title deps: Bump arrow-format to 0.8 Bumped arrow-format to 0.8 Nov 13, 2022
@jorgecarleitao jorgecarleitao merged commit 245f072 into jorgecarleitao:main Nov 13, 2022
@jorgecarleitao
Copy link
Owner

Thanks, @Xuanwo ! 🙇

@Xuanwo Xuanwo deleted the bump-arrow-format branch November 13, 2022 13:07
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tonic and prost dependencies in arrow-format respectively to 0.8.x and 0.11.x
2 participants