Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Improved UnionArray #1331

Merged
merged 3 commits into from Dec 18, 2022
Merged

Improved UnionArray #1331

merged 3 commits into from Dec 18, 2022

Conversation

jorgecarleitao
Copy link
Owner

  • Improved invariants checks
  • Improved performance of iteration
  • Simplified code
  • Added more tests

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 83.09% // Head: 83.14% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (50222d8) compared to base (12d955d).
Patch coverage: 88.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
+ Coverage   83.09%   83.14%   +0.05%     
==========================================
  Files         370      370              
  Lines       40157    40196      +39     
==========================================
+ Hits        33367    33421      +54     
+ Misses       6790     6775      -15     
Impacted Files Coverage Δ
src/array/growable/union.rs 72.60% <0.00%> (ø)
src/array/union/mod.rs 84.61% <89.65%> (+8.06%) ⬆️
src/array/union/iterator.rs 61.90% <100.00%> (ø)
src/compute/sort/row/mod.rs 77.41% <100.00%> (ø)
src/compute/sort/row/variable.rs 100.00% <100.00%> (ø)
src/io/json_integration/read/array.rs 85.75% <100.00%> (+0.03%) ⬆️
src/io/ipc/read/file.rs 96.87% <0.00%> (-0.45%) ⬇️
src/offset.rs 84.89% <0.00%> (+0.35%) ⬆️
src/array/fixed_size_binary/mod.rs 85.56% <0.00%> (+0.53%) ⬆️
src/array/binary/mod.rs 92.12% <0.00%> (+1.18%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao merged commit c8699d8 into main Dec 18, 2022
@jorgecarleitao jorgecarleitao deleted the union branch December 18, 2022 16:57
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant