Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

fix(parquet): nested struct /list writing #1347

Merged
merged 1 commit into from Dec 30, 2022

Conversation

ritchie46
Copy link
Collaborator

fixes #1325

@codecov
Copy link

codecov bot commented Dec 25, 2022

Codecov Report

Base: 83.17% // Head: 83.16% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2e126d4) compared to base (2101c8e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
- Coverage   83.17%   83.16%   -0.01%     
==========================================
  Files         370      370              
  Lines       40191    40216      +25     
==========================================
+ Hits        33427    33444      +17     
- Misses       6764     6772       +8     
Impacted Files Coverage Δ
src/io/parquet/write/nested/rep.rs 99.47% <100.00%> (+0.07%) ⬆️
src/io/ipc/read/array/boolean.rs 90.74% <0.00%> (-7.41%) ⬇️
src/array/binary/mod.rs 90.94% <0.00%> (-1.19%) ⬇️
src/array/utf8/mod.rs 84.94% <0.00%> (-1.01%) ⬇️
src/offset.rs 84.89% <0.00%> (+0.35%) ⬆️
src/io/ipc/read/file.rs 96.87% <0.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Dec 30, 2022
@jorgecarleitao jorgecarleitao merged commit 20efe26 into jorgecarleitao:main Dec 30, 2022
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid written parquet file of nested structures. (Mixing list with structs)
2 participants