Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made IPC writer take owned schema #1361

Merged
merged 1 commit into from Jan 18, 2023

Conversation

ritchie46
Copy link
Collaborator

The ipc writer takes a schema reference, but directly clowns it to an owned schema. This leads to a redundant clone when a user first constructs the arrow schema.

@ritchie46 ritchie46 force-pushed the owned_schema branch 2 times, most recently from d0cd690 to 017a9bf Compare January 16, 2023 12:51
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 83.28% // Head: 83.33% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (919029c) compared to base (211be21).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
+ Coverage   83.28%   83.33%   +0.04%     
==========================================
  Files         371      371              
  Lines       40239    40317      +78     
==========================================
+ Hits        33515    33600      +85     
+ Misses       6724     6717       -7     
Impacted Files Coverage Δ
src/io/ipc/mod.rs 100.00% <ø> (ø)
src/io/ipc/write/writer.rs 89.92% <100.00%> (-4.30%) ⬇️
src/io/ipc/read/reader.rs 84.52% <0.00%> (-10.15%) ⬇️
src/io/csv/read/infer_schema.rs 97.43% <0.00%> (-2.57%) ⬇️
src/array/growable/structure.rs 95.34% <0.00%> (-1.00%) ⬇️
src/io/ipc/read/file.rs 96.42% <0.00%> (-0.90%) ⬇️
src/io/ipc/read/schema.rs 95.57% <0.00%> (-0.30%) ⬇️
src/temporal_conversions.rs 90.22% <0.00%> (ø)
src/io/ipc/write/common_sync.rs 94.44% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao changed the title IPC writer: take owned schema Made IPC writer take owned schema Jan 18, 2023
@jorgecarleitao jorgecarleitao merged commit 70571d6 into jorgecarleitao:main Jan 18, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants