Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Amortized intermediate allocations in IPC writer #1362

Merged
merged 4 commits into from Jan 16, 2023

Conversation

ritchie46
Copy link
Collaborator

This reuses the encoded_message per write call. Besides from this, the encoded_message can also be used in between multiple writers, so that the amount of allocations is reduced.

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 83.28% // Head: 83.29% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (15ab4e5) compared to base (211be21).
Patch coverage: 86.27% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1362   +/-   ##
=======================================
  Coverage   83.28%   83.29%           
=======================================
  Files         371      371           
  Lines       40239    40268   +29     
=======================================
+ Hits        33515    33542   +27     
- Misses       6724     6726    +2     
Impacted Files Coverage Δ
src/io/flight/mod.rs 38.06% <0.00%> (ø)
src/io/ipc/compression.rs 100.00% <ø> (ø)
src/temporal_conversions.rs 90.22% <ø> (ø)
src/io/ipc/write/writer.rs 89.92% <50.00%> (-4.30%) ⬇️
src/io/ipc/append/mod.rs 91.30% <100.00%> (+0.19%) ⬆️
src/io/ipc/write/common.rs 82.22% <100.00%> (+1.54%) ⬆️
src/io/ipc/write/common_sync.rs 94.44% <100.00%> (ø)
src/io/ipc/write/stream.rs 85.96% <100.00%> (ø)
src/io/ipc/read/file.rs 96.42% <0.00%> (-0.90%) ⬇️
src/bitmap/immutable.rs 86.66% <0.00%> (+0.60%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ritchie46 ritchie46 changed the title Ipc writer: amortize intermediate allocations. IPC writer: amortize intermediate allocations. Jan 16, 2023
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jan 16, 2023
@jorgecarleitao jorgecarleitao changed the title IPC writer: amortize intermediate allocations. Amortized intermediate allocations in IPC writer Jan 16, 2023
@jorgecarleitao jorgecarleitao merged commit 4ed6f26 into jorgecarleitao:main Jan 16, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants