Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for take of FixedSizeListArray #1386

Merged

Conversation

kylebarron
Copy link
Contributor

@kylebarron kylebarron commented Feb 7, 2023

👋 This adds an implementation of take for FixedSizeListArray (essentially just copied from the list implementation). Let me know if it looks good and then I can add a test with null values as well, mimicking the ListArray tests

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 83.33% // Head: 83.36% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (4e8797f) compared to base (40182a1).
Patch coverage: 77.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1386      +/-   ##
==========================================
+ Coverage   83.33%   83.36%   +0.03%     
==========================================
  Files         371      373       +2     
  Lines       40321    40398      +77     
==========================================
+ Hits        33602    33679      +77     
  Misses       6719     6719              
Impacted Files Coverage Δ
src/compute/take/fixed_size_list.rs 75.75% <75.75%> (ø)
src/compute/take/mod.rs 89.47% <100.00%> (+0.58%) ⬆️
src/ffi/mod.rs 100.00% <0.00%> (ø)
src/mmap/mod.rs 84.84% <0.00%> (ø)
src/mmap/array.rs 96.63% <0.00%> (ø)
src/bitmap/immutable.rs 86.66% <0.00%> (+0.60%) ⬆️
src/array/utf8/mod.rs 85.80% <0.00%> (+0.99%) ⬆️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️
src/ffi/mmap.rs 98.85% <0.00%> (+2.10%) ⬆️
src/chunk.rs 90.47% <0.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Feb 8, 2023
@jorgecarleitao jorgecarleitao changed the title Implement take kernel for FixedSizeListArray Added take kernel for FixedSizeListArray Feb 8, 2023
@jorgecarleitao jorgecarleitao changed the title Added take kernel for FixedSizeListArray Added support for take kernel for FixedSizeListArray Feb 8, 2023
@jorgecarleitao jorgecarleitao changed the title Added support for take kernel for FixedSizeListArray Added support for take of FixedSizeListArray Feb 8, 2023
@jorgecarleitao jorgecarleitao merged commit 6a05c6b into jorgecarleitao:main Feb 8, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants