Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed broken guide link #1395

Merged
merged 1 commit into from Feb 12, 2023
Merged

Fixed broken guide link #1395

merged 1 commit into from Feb 12, 2023

Conversation

kjschiroo
Copy link
Contributor

It looks like there is a typo in the csv read documentation causing the existing link on the README.md page to result in a 404. Rather than change the README.md link from csv_read to csv_reader this PR changes the filename from csv_reader to csv_read and updates the only other existing reference to the file. This path was taken to make the filename align with the wider pattern within the guide while also addressing the broken link.

It looks like there is a typo in the csv read documentation
causing the existing link on the README.md page to result in a 404.
Rather than change the README.md link from `csv_read` to `csv_reader`
this PR changes the filename from `csv_reader` to `csv_read` and updates
the only other existing reference to the file. This path was taken to
make the filename align with the wider pattern within the guide while
also addressing the broken link.
@jorgecarleitao jorgecarleitao added the documentation Improvements or additions to documentation label Feb 12, 2023
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Base: 83.49% // Head: 83.47% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (0af1768) compared to base (7be484e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
- Coverage   83.49%   83.47%   -0.02%     
==========================================
  Files         373      373              
  Lines       40758    40758              
==========================================
- Hits        34029    34023       -6     
- Misses       6729     6735       +6     
Impacted Files Coverage Δ
src/io/ipc/read/array/boolean.rs 92.45% <0.00%> (-5.67%) ⬇️
src/array/binary/mod.rs 90.94% <0.00%> (-1.19%) ⬇️
src/io/ipc/read/file.rs 96.42% <0.00%> (-0.45%) ⬇️
src/bitmap/immutable.rs 86.66% <0.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao changed the title Fix broken guide link Fixed broken guide link Feb 12, 2023
@jorgecarleitao jorgecarleitao merged commit 58fdaeb into jorgecarleitao:main Feb 12, 2023
@jorgecarleitao
Copy link
Owner

Thank you @kjschiroo ! 🙇

ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
It looks like there is a typo in the csv read documentation
causing the existing link on the README.md page to result in a 404.
Rather than change the README.md link from `csv_read` to `csv_reader`
this PR changes the filename from `csv_reader` to `csv_read` and updates
the only other existing reference to the file. This path was taken to
make the filename align with the wider pattern within the guide while
also addressing the broken link.
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
It looks like there is a typo in the csv read documentation
causing the existing link on the README.md page to result in a 404.
Rather than change the README.md link from `csv_read` to `csv_reader`
this PR changes the filename from `csv_reader` to `csv_read` and updates
the only other existing reference to the file. This path was taken to
make the filename align with the wider pattern within the guide while
also addressing the broken link.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants