Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Improved API of getting mutable from Buffer #1399

Merged
merged 2 commits into from Feb 13, 2023
Merged

Improved API of getting mutable from Buffer #1399

merged 2 commits into from Feb 13, 2023

Conversation

jorgecarleitao
Copy link
Owner

Aligned it across Bitmap -> MutableBitmap and Offsets -> OffsetsBuffer.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 83.49% // Head: 83.80% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (6e69ce6) compared to base (7be484e).
Patch coverage: 92.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
+ Coverage   83.49%   83.80%   +0.30%     
==========================================
  Files         373      373              
  Lines       40758    41710     +952     
==========================================
+ Hits        34029    34953     +924     
- Misses       6729     6757      +28     
Impacted Files Coverage Δ
src/buffer/immutable.rs 89.65% <87.50%> (-0.59%) ⬇️
src/array/primitive/mod.rs 87.50% <88.88%> (+3.16%) ⬆️
src/array/utf8/mod.rs 86.48% <90.00%> (+1.66%) ⬆️
src/array/binary/mod.rs 95.97% <100.00%> (+3.84%) ⬆️
src/offset.rs 83.59% <100.00%> (-2.03%) ⬇️
src/io/ipc/read/array/boolean.rs 92.45% <0.00%> (-5.67%) ⬇️
src/array/null.rs 51.57% <0.00%> (-0.99%) ⬇️
src/array/dictionary/mod.rs 92.94% <0.00%> (-0.26%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao merged commit 4203f9a into main Feb 13, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
* Removed potential source of UB

* Improved API
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
* Removed potential source of UB

* Improved API
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant