This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Added apply_validity and set_validity to mutable utf8 array #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arty-Maly
force-pushed
the
apply_validity
branch
from
9628d2e
to
3ab756a
Compare
Codecov ReportBase: 83.63% // Head: 83.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1406 +/- ##
==========================================
- Coverage 83.63% 83.60% -0.04%
==========================================
Files 373 373
Lines 40284 40299 +15
==========================================
Hits 33692 33692
- Misses 6592 6607 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jorgecarleitao
changed the title
|
Looks perfect. Thank you! |
jorgecarleitao
pushed a commit
that referenced
this pull request
Feb 14, 2023
add apply_validity and set_validity to mutable utf8 array Co-authored-by: artem.malyshev <artem.malyshev@bytedance.com>
jgmartin
pushed a commit
to jgmartin/arrow2
that referenced
this pull request
Feb 22, 2023
…leitao#1406) add apply_validity and set_validity to mutable utf8 array Co-authored-by: artem.malyshev <artem.malyshev@bytedance.com>
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 29, 2023
…leitao#1406) add apply_validity and set_validity to mutable utf8 array Co-authored-by: artem.malyshev <artem.malyshev@bytedance.com>
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Apr 5, 2023
…leitao#1406) add apply_validity and set_validity to mutable utf8 array Co-authored-by: artem.malyshev <artem.malyshev@bytedance.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to my previous pr for
Utf8ArrayI am adding two methods:
set_validityandapply_validityforMutableUtf8ArrayThis was pretty straightforward to add so I preemptively created a pr without double checking if it is something that would be accepted.
@jorgecarleitao Let me know if this looks good.