Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for MapArray read and write to parquet #1419

Merged
merged 18 commits into from Feb 28, 2023

Conversation

b41sh
Copy link
Contributor

@b41sh b41sh commented Feb 24, 2023

implement Map data type read and write for parquet

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 83.66% // Head: 83.63% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (c6cc76f) compared to base (c877287).
Patch coverage: 87.04% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
- Coverage   83.66%   83.63%   -0.03%     
==========================================
  Files         373      374       +1     
  Lines       40340    40603     +263     
==========================================
+ Hits        33749    33960     +211     
- Misses       6591     6643      +52     
Impacted Files Coverage Δ
src/array/fmt.rs 64.70% <0.00%> (-0.97%) ⬇️
src/array/growable/mod.rs 83.09% <0.00%> (ø)
src/array/map/mod.rs 62.13% <ø> (ø)
src/io/parquet/read/mod.rs 100.00% <ø> (ø)
src/io/parquet/write/mod.rs 86.77% <0.00%> (-1.06%) ⬇️
src/io/parquet/read/indexes/mod.rs 80.71% <66.66%> (-0.22%) ⬇️
src/io/parquet/read/deserialize/mod.rs 75.73% <80.76%> (+1.18%) ⬆️
src/array/growable/map.rs 85.91% <85.91%> (ø)
src/io/parquet/write/pages.rs 95.84% <94.82%> (-0.29%) ⬇️
src/io/parquet/read/deserialize/nested.rs 72.96% <100.00%> (-0.32%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks great! Could you add a test (e.g. roundtrip)?

@jorgecarleitao jorgecarleitao changed the title feat(parquet): implement Map data type read and write Added support for MapArray read and write to parquet Feb 28, 2023
@jorgecarleitao jorgecarleitao added the feature A new feature label Feb 28, 2023
@jorgecarleitao jorgecarleitao merged commit d06323a into jorgecarleitao:main Feb 28, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants