Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Updated multiversion and support wider registers #1440

Merged
merged 1 commit into from Mar 26, 2023

Conversation

ritchie46
Copy link
Collaborator

Currently the simd sum only used 128 bit registers via runtime detection. This adds support for all simd available targets.

Had a 4x improvement on a local compilation. Updated multiversion while at it.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (7d52276) 83.79% compared to head (5e9e574) 83.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1440      +/-   ##
==========================================
- Coverage   83.79%   83.76%   -0.04%     
==========================================
  Files         376      376              
  Lines       41128    41010     -118     
==========================================
- Hits        34463    34351     -112     
+ Misses       6665     6659       -6     
Impacted Files Coverage Δ
src/compute/aggregate/min_max.rs 72.72% <100.00%> (-7.83%) ⬇️
src/compute/aggregate/sum.rs 77.08% <100.00%> (-6.67%) ⬇️
src/compute/hash.rs 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Mar 26, 2023
@jorgecarleitao jorgecarleitao changed the title feat: update multiversion and support wider registers Updated multiversion and support wider registers Mar 26, 2023
@jorgecarleitao jorgecarleitao merged commit 3735bfd into jorgecarleitao:main Mar 26, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants