Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Make merge_sort_slices MergeSortSlices public #243

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

sundy-li
Copy link
Collaborator

@sundy-li sundy-li commented Aug 1, 2021

In OLAP database system, sort/merge_sort is not just for one column.

The unit of sort compute is block, we should make merge_sort_slices public, then we can take the indices from the block to build new blocks.

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #243 (ea2f82d) into main (eea4d33) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   76.81%   76.81%           
=======================================
  Files         229      229           
  Lines       19617    19617           
=======================================
  Hits        15068    15068           
  Misses       4549     4549           
Impacted Files Coverage Δ
src/compute/merge_sort/mod.rs 94.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea4d33...ea2f82d. Read the comment docs.

@sundy-li
Copy link
Collaborator Author

sundy-li commented Aug 1, 2021

We also need materialize_merge_indices to reuse the iterator to sort other arrays.

Something like:

https://github.com/datafuselabs/datafuse/blob/8dbd277f90a7251806d90ccbe002b51954c63526/common/datablocks/src/kernels/data_block_sort.rs#L135-L161

@jorgecarleitao jorgecarleitao merged commit 01df0a6 into jorgecarleitao:main Aug 2, 2021
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants