Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in slicing bitmap. #250

Merged
merged 1 commit into from Aug 4, 2021
Merged

Fixed error in slicing bitmap. #250

merged 1 commit into from Aug 4, 2021

Conversation

jorgecarleitao
Copy link
Owner

When the slice has an offset and crosses a byte, we need to also take that byte into account.

Thanks to @ritchie46 for initially reporting it. 👍

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Aug 4, 2021
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #250 (41fb510) into main (fa3c2ce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   76.81%   76.81%           
=======================================
  Files         229      229           
  Lines       19617    19628   +11     
=======================================
+ Hits        15068    15078   +10     
- Misses       4549     4550    +1     
Impacted Files Coverage Δ
src/bitmap/immutable.rs 87.34% <100.00%> (+1.04%) ⬆️
src/bitmap/utils/slice_iterator.rs 96.57% <100.00%> (+0.14%) ⬆️
src/io/csv/write/mod.rs 87.50% <0.00%> (-2.78%) ⬇️
src/io/parquet/read/binary/nested.rs 86.41% <0.00%> (-1.39%) ⬇️
src/compute/cast/timestamps.rs 93.58% <0.00%> (-1.29%) ⬇️
src/compute/arithmetics/mod.rs 51.12% <0.00%> (-0.76%) ⬇️
src/compute/merge_sort/mod.rs 93.70% <0.00%> (-0.40%) ⬇️
src/io/parquet/write/mod.rs 69.57% <0.00%> (-0.33%) ⬇️
src/compute/comparison/mod.rs 90.72% <0.00%> (+0.09%) ⬆️
src/io/json/schema.rs 42.12% <0.00%> (+0.28%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3c2ce...41fb510. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 1908eb7 into main Aug 4, 2021
@jorgecarleitao jorgecarleitao deleted the fix_slice branch August 4, 2021 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant