Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in computing remainder of chunk iterator #262

Merged
merged 1 commit into from Aug 9, 2021

Conversation

jorgecarleitao
Copy link
Owner

It was not correct when the remainder contained more than 1 relevant byte.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #262 (4b49916) into main (d545253) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   76.76%   76.92%   +0.16%     
==========================================
  Files         232      232              
  Lines       19820    20438     +618     
==========================================
+ Hits        15214    15722     +508     
- Misses       4606     4716     +110     
Impacted Files Coverage Δ
src/bitmap/utils/chunk_iterator/mod.rs 93.10% <100.00%> (+0.34%) ⬆️
src/bitmap/utils/mod.rs 100.00% <100.00%> (ø)
src/io/print.rs 97.63% <0.00%> (+0.77%) ⬆️
src/array/mod.rs 53.15% <0.00%> (+0.90%) ⬆️
src/array/primitive/mutable.rs 66.81% <0.00%> (+1.32%) ⬆️
src/io/csv/write/mod.rs 88.88% <0.00%> (+1.38%) ⬆️
src/array/dictionary/mutable.rs 87.50% <0.00%> (+5.00%) ⬆️
src/compute/aggregate/min_max.rs 94.50% <0.00%> (+8.24%) ⬆️
src/compute/cast/utf8_to.rs 27.45% <0.00%> (+13.72%) ⬆️
src/compute/cast/mod.rs 43.87% <0.00%> (+16.77%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d545253...4b49916. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 6b6acb8 into main Aug 9, 2021
@jorgecarleitao jorgecarleitao deleted the fix_chunk_iter branch August 9, 2021 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant